fix(ci): build db dep closure before db:generate (DB Migrate)#4
Merged
Conversation
The `diff` job ran `db:generate` straight after install, but drizzle.config.ts imports `@cheatcode/env/migrate` (built ./dist), so it failed with "Cannot find module @cheatcode/env/dist/migrate.js" on a fresh runner. Build `@cheatcode/db^...` (its workspace dep closure) first. Also add this workflow to the pull_request paths so workflow changes self-validate the diff job.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
db:generate never connects but drizzle.config.ts eagerly requires a URL; supply a placeholder. The migration-plan step needs a real DB and the SUPABASE_MIGRATION_URL secret isn't configured, so guard it on the secret being present. Drift check (generate + git diff) is the gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red
DB Migrate › diffcheck. The job randb:generatebefore building@cheatcode/env, whose built./dist/migrate.jsis imported bydrizzle.config.ts→ "Cannot find module". Now builds@cheatcode/db^...first. Verified locally by removing env/dist and reproducing. Also added this workflow topathsso it self-validates here.